fix(issues): claim a new Session on @new-then-resume comments - #1224
Open
RainMona wants to merge 3 commits into
Open
fix(issues): claim a new Session on @new-then-resume comments#1224RainMona wants to merge 3 commits into
RainMona wants to merge 3 commits into
Conversation
Rebinding a Telegram desk (or any scheduled Issue) to "New Session · assign after first run" left inbound comments following creator or prior-reconstruction provenance, so chat kept the old Session. Treat current assignee as the only comment-dispatch contract: @new-then-resume now recruits a fresh Workspace Session and claims it, matching the first scheduled fire. Co-authored-by: RainMona <RainMona@users.noreply.github.com>
Bring the fork feature branch onto current TraderAlice/dev (connector phone-desk generalization, Auto Prediction harness, and related Issue surfaces). Keep current assignee as the only comment-dispatch contract: @new-then-resume comments still recruit and claim a first Session. Co-authored-by: RainMona <RainMona@users.noreply.github.com>
Keep the branch current with TraderAlice/dev before opening the upstream PR. Co-authored-by: RainMona <RainMona@users.noreply.github.com>
|
@cursoragent is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebinding a Connector / Telegram phone-desk Issue to New Session · assign after first run (
@new-then-resume) left inbound chat on the previous Session.This is an external proposal from
RainMona/OpenAlice, based on currentTraderAlice/dev(ab06cbf2). PerCONTRIBUTING.md, treat it as a reference if you would rather reimplement on a maintainer-owned branch.Problem
Scheduled fires already recruit a fresh Session and rewrite
assigneeto that@resumeId. Comment replies did not.dispatchIssueCommentReplytreated “no exact@resumeId” as unowned work and used{ kind: 'issue', action: 'created' }plusreconstruct: true. That continues creator / prior-reconstruction provenance, so a Telegram / Connector DM after a rebind kept talking to the old Session.Decision
Current
assigneeis the only comment-dispatch contract.@resumeId@new-then-resume@new-each-run/@unassigned/@humanAlternatives considered:
This is a design choice from the reported bug, not a maintainer-approved product review.
Changes
claimIssueFirstSession/issueRuntimeSelectionso schedule and comments share one claim path@new-then-resumecomment dispatch uses{ kind: 'workspace' }(no reconstruct),relation: 'owner', then claimsaskforwards credential / model / effort only when recruiting a fresh Sessionissue_commentpass the claim depsVerification
On the synced tip:
npx tsc --noEmitandcd ui && npx tsc -bpassedclaim-session,comment-delivery,telegram-desk-chat,conversation-control,scanner, issue routes, issue tools)CI / test,build, docker smoke, cross-platform tests, platformdev-smoke)No browser walk: this is comment-dispatch / assignee lifecycle. Composer hint copy only.
Boundary touch
Issue assignee lifecycle, comment dispatch, Connector phone-desk ingest. No trading writes, credentials, or migrations.
Non-goals
@new-each-run/@unassigned/@humancomment fallbackassignee