fix(settings): FMP Test key uses EquitySearch, matching Intrinio - #1147
Open
bishallllllll wants to merge 1 commit into
Open
fix(settings): FMP Test key uses EquitySearch, matching Intrinio#1147bishallllllll wants to merge 1 commit into
bishallllllll wants to merge 1 commit into
Conversation
|
@bishallllllll is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Settings → Market Data → Advanced “Test FMP key” probe to use the lighter EquitySearch model (aligned with Intrinio’s probe) instead of the heavier EquityScreener call.
Changes:
- Switch FMP test-key endpoint model from
EquityScreenertoEquitySearch. - Provide a concrete query (
AAPL) for the FMPEquitySearchprobe to validate credentials.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@copilot Fix the code for all comments in this review thread. When a review comment includes a suggested change, apply the suggestion exactly. Do not make changes beyond what is described in the linked review thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FMP Test-key endpoint: use EquitySearch (matches Intrinio)
Settings → Market Data → Advanced: the "Test FMP key" button probes a key via the Test-key endpoint. FMP was using
EquityScreener {limit:1}while Intrinio already usesEquitySearch {query:'AAPL', limit:1}. This makes FMP consistent (and the screener endpoint is a heavier call for a key probe).src/webui/routes/config.ts— one-line change inTEST_ENDPOINTS;EquitySearchis a registered FMP fetcher (packages/opentypebb/src/providers/fmp/index.ts:135)npx tsc --noEmitcleanarea:settings,area:market-data