Fix extra vertical space for long document titles #864
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrybleiberg
changed the title
kasbah
requested changes
Nov 25, 2025
Member
kasbah
left a comment
kasbah
left a comment
There was a problem hiding this comment.
Thanks for this @perrybleiberg but don't think we should ad-hoc affect the style of this element from the outside like this.
We have a lot of clean up to do in terms of encapsulating styles within our components but I believe this should be fixed inside ui-components rather than from the outside.
Contributor
Author
|
Thanks for taking a look Kaspar, I'll try again and/or follow your lead here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #818. Even when the text in an InlineInput does not wrap, line break opportunities in the input force the hidden inline-input-filler span to account for wrapping, causing the extra space. The change prevents this from happening in document-head.