fix: do not ignore host when connect tls#367
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
how to work with changeset @TooTallNate |
|
@lukekarrys should I reformat the code for passing CI, any local format instructions for me? |
d336ae6 to
e7fec9f
Compare
@lukekarrys Sorry, it's not the problem of lint, it's the problem of format task. I've already fix the format problem, could you help me to re-trigger the |
|
Hello @TooTallNate 👋 Sorry to bother I'm also hitting an issue where this would fix it. The root cause is the same although my issue is a bit different. We're trying to hit a DNS server with an HTTPS proxy using an IP address (on my case cloudflare: 1.1.1.1 DNS resolver I dug through the history and saw that the lib added code to correctly not set SNI for IPs, but in doing so also drops the I thought I'd bring it up. Let me know if I can help |
for bilateral tls verification, the
hostshould not be ignored, if thehostfield be ignored, it will be set tolocalhostautomatically. But the default host(localhost) is not correspoding to tls certificate.for kubernetes it will use bilateral tls verification, for tls website it will use single tls verification. And I've already tested the traditional tls web site and the communication of kuberntes apiserver two traditional cases, it all works ok.
relasted issues: #365