[stankudrow]

Closes #160 .
Also may close #167 .
Potentially closes #207 .

Features:

• to_agen for wrapping synchronous generators;
• wrap uses asyncio.to_thread under the hood because Python3.9 is minimum version;
• the asynchronous versions of the os.walk and os.fwalk (Linux only) are added (to_agen made it possible)
• tests updated and test execution order is randomised for each run by default
• minor changes

[Tinche]

Apologies. I have a small baby nowadays.

So the original sync os.walk is a generator, right? This has some very useful properties which we should keep. Can we make the async version an async generator? Each step can do a step of the sync one.

[stankudrow]

Apologies. I have a small baby nowadays.

So the original sync os.walk is a generator, right? This has some very useful properties which we should keep. Can we make the async version an async generator? Each step can do a step of the sync one.

Hello and no need for apologies, au contraire, congratulations.

[Martin005]

Waits for the #199 to be merged.

That PR has been merged now, can we please merge this one as well? 🙂

[Tinche]

Thanks for your patience. I'm going to review this in the next couple of days.

[Tinche]

Prior to Python 3.12 this fails because inspect.isgeneratorfunction(os.walk) is False and since Py3.12 it is True. Any ideas how to have goodies from both realms -> having one wrap which can handle routines and generator functions (or functions that return an iterator object) and are universal enough to work for Py3.9+ versions?

I wouldn't go through gymnastics to make this work - we know when we're wrapping a generator and when an ordinary function. Two functions are perfectly fine IMO.

[Tinche]

I'm very unconvinced by the implementation of to_agen. To me it looks like it's essentially performing a spin-lock while waiting for the (sync) queue to return anything. There's a while True: with a continue in a branch.

Let me think about doing this in a better way. Bridging async and sync is going to be a little tricky here.