feat: enable sorting for CH with list variable

[zepfred]

No description provided.

[zepfred]

@triceo I noticed other factories used by configurations and annotations that are not located in the public API. Maybe, we should handle that in a separate PR as well.

[triceo]

As always, the different selector combinations are causing me to ask questions - see inline.

Downstream tests are failing.

Also, please provide a migration recipe for the move of the interface to the public API; the uses of the old interface should be replaced by the new one.

Finally, the change needs to show up in the upgrade recipe in our docs.

[zepfred]

Finally, the change needs to show up in the upgrade recipe in our docs.

I have included a recipe for automatic migration to the new interface. Do we need to add anything to our docs?

[zepfred]

@triceo we include the property sorterWeightFactoryClass in EntitySelectorConfig, ValueSelectorConfig, and MoveSelectorConfig. Should we deprecate it and introduce a new property called sorterComparatorFactoryClass?

The property sorterWeightFactoryClass is already of type ComparatorFactory.

[triceo]

@triceo we include the property sorterWeightFactoryClass in EntitySelectorConfig, ValueSelectorConfig, and MoveSelectorConfig. Should we deprecate it and introduce a new property called sorterComparatorFactoryClass?

Yes, the old names should be deprecated. Code which uses them should still work, but the code which combines the old names and the new names should fail fast - it's either all the old names, or all the new names.

Arguably sorterComparatorFactoryClass - why not just ComparatorFactoryClass? I'm not sure.

[zepfred]

@triceo we include the property sorterWeightFactoryClass in EntitySelectorConfig, ValueSelectorConfig, and MoveSelectorConfig. Should we deprecate it and introduce a new property called sorterComparatorFactoryClass?

Yes, the old names should be deprecated. Code which uses them should still work, but the code which combines the old names and the new names should fail fast - it's either all the old names, or all the new names.

Arguably sorterComparatorFactoryClass - why not just ComparatorFactoryClass? I'm not sure.

We already have sorterComparatorClass of type Comparator

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.3% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud