fix: Handle empty playlist

[Hazmi35]

This should fix #121

[Hazmi35]

We could use optional chaining here but that requires node v14.5.0 or above, so I used the ternary operator to be compatible with node v8. I do recommend you bump node to v14.5.0 or above because v8 is EOL and v12 is going to EOL next year

[Hazmi35]

With optional chaining the updated code should look like this

const rawVideoList = parsed.json.contents
    .twoColumnBrowseResultsRenderer.tabs[0].tabRenderer.content
    .sectionListRenderer.contents[0]
    .itemSectionRenderer.contents[0]
    .playlistVideoListRenderer?.contents;

if (rawVideoList === undefined) throw new Error('Playlist is empty');

[Hazmi35]

With the current changes, it would be like this with optional chaining

const playlistVideoListRenderer = parsed.json.contents
    .twoColumnBrowseResultsRenderer.tabs[0].tabRenderer.content
    .sectionListRenderer.contents[0]
    .itemSectionRenderer.contents[0]
    .playlistVideoListRenderer?.contents ?? [];

[Hazmi35]

Should test for empty playlist created too?

[TimeForANinja]

would be cool 😅

[codecov]

Codecov Report

Merging #122 (d3519ab) into master (fcc26a1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          260       261    +1     
=========================================
+ Hits           260       261    +1     

Impacted Files	Coverage Δ
lib/main.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc26a1...d3519ab. Read the comment docs.

[TimeForANinja]

i'm also more of a empty array fan since doing that you'd get meta information like playlist title and so on...

[Hazmi35]

i'm also more of a empty array fan since doing that you'd get meta information like playlist title and so on...

Yes, I didn't think of that before, changed in d3519ab.

Do the test still need to be created?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Hazmi35]

This should be reopened when you're ready.

[TimeForANinja]

not quite ready but i can at least tell the stale bot to ignore this 😉