New landing page#525
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93dda32549
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| {% include 'includes/analytics/analytics_body.html' %} | ||
|
|
||
| <div id="app"></div> | ||
| {% vite_asset 'src/landing.jsx' %} |
There was a problem hiding this comment.
new_landing.html now renders {% vite_asset 'src/landing.jsx' %}, but this commit does not add src/landing.jsx as a Vite build input (the build config still only targets src/index.jsx). In production (manifest mode), this causes the landing asset lookup to fail for unauthenticated users and can return a server error when rendering /.
Useful? React with 👍 / 👎.
| import { createRoot } from 'react-dom/client'; | ||
| import { BrowserRouter, Routes, Route } from 'react-router-dom'; // landing page | ||
| import App from 'components/App'; | ||
| import Landing from 'components/Landing'; |
There was a problem hiding this comment.
Importing components/Landing in index.jsx has side effects because that module imports global CSS and large SVG assets, so the authenticated planner entrypoint now pulls landing-page styles/assets even though <Landing /> is never rendered there. This increases bundle weight and can leak global style rules into the main app unnecessarily.
Useful? React with 👍 / 👎.
1 participant
No description provided.