Skip to content

Fix stale prerequisite validation when switching from Docker to Podman #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iamliuxiaozhen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix stale prerequisite validation when switching from Docker to Podman #757

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0dd44b
Fix stale prerequisite state when switching runtimes
Iamliuxiaozhen Apr 18, 2026
8023b98
Fix missing computedAsync import in setup UI
Iamliuxiaozhen Apr 19, 2026
f0f7094
Disable setup next button while checking runtime prerequisites
Iamliuxiaozhen Apr 21, 2026
b7de5d5
fix(setup-ui): harden runtime switch and step navigation
Iamliuxiaozhen Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 41 additions & 9 deletions src/renderer/views/SetupUI.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,16 @@
<span v-else class="text-red-500">✘</span>

<div>
<x-select
@change="(e: any) => (containerRuntime = e.detail.newValue)"
class="w-fit"
>
<x-select @change="handleContainerRuntimeChange" class="w-fit">
<x-menu>
<x-menuitem
v-for="(runtime, key) in Object.values(ContainerRuntimes)"
:key="key"
:value="runtime"
:toggled="runtime === containerRuntime"
@pointerdown="beginContainerRuntimeChange(runtime)"
@keydown.enter="beginContainerRuntimeChange(runtime)"
@click="beginContainerRuntimeChange(runtime)"
>
<x-label>{{ runtime }}</x-label>
</x-menuitem>
Expand Down Expand Up @@ -245,8 +245,8 @@
<x-button
toggled
class="px-6"
@click="currentStepIdx++"
:disabled="!satisfiesPrequisites(specs, containerSpecs)"
@click="goToInstallLocationStep"
:disabled="checkingPrerequisites || !satisfiesPrequisites(specs, containerSpecs)"
>
Next
</x-button>
Expand Down Expand Up @@ -821,6 +821,7 @@ import { openAnchorLink } from "../utils/openLink";
import license from "../assets/LICENSE.txt?raw";
import {
ContainerRuntimes,
type ContainerSpecs,
DockerSpecs,
PodmanSpecs,
getContainerSpecs,
Expand Down Expand Up @@ -936,6 +937,7 @@ const sharedFolderPath = ref("");
const installState = ref<InstallStates>(InstallStates.IDLE);
const preinstallMsg = ref("");
const containerRuntime = ref(ContainerRuntimes.DOCKER);
const checkingPrerequisites = ref(true);
const vncPort = ref(8006);
// These are the install steps where the container is actually up and running
const linkableInstallSteps = [ InstallStates.MONITORING_PREINSTALL, InstallStates.INSTALLING_WINDOWS, InstallStates.COMPLETED ];
Expand Down Expand Up @@ -972,9 +974,39 @@ watch(folderSharing, (newValue) => {
}
});

const containerSpecs = computedAsync(async () => {
return await getContainerSpecs(containerRuntime.value);
});
const containerSpecs = ref<ContainerSpecs>();

watch(
containerRuntime,
async runtime => {
checkingPrerequisites.value = true;
containerSpecs.value = undefined;
try {
containerSpecs.value = await getContainerSpecs(runtime);
} finally {
checkingPrerequisites.value = false;
}
},
{ immediate: true },
);

function handleContainerRuntimeChange(e: CustomEvent<{ newValue: ContainerRuntimes }>) {
beginContainerRuntimeChange(e.detail.newValue);
}

function beginContainerRuntimeChange(runtime: ContainerRuntimes) {
if (runtime === containerRuntime.value) return;

checkingPrerequisites.value = true;
containerSpecs.value = undefined;
containerRuntime.value = runtime;
}

function goToInstallLocationStep() {
if (checkingPrerequisites.value || !satisfiesPrequisites(specs.value, containerSpecs.value)) return;

currentStepIdx.value++;
}

function containerInstalled(containerSpecs: DockerSpecs | PodmanSpecs | undefined) {
if (!containerSpecs) return false;
Expand Down