feat!: tskit error variants#138
Open
laggycomputer wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
We can merge this second. |
molpopgen
requested changes
Jun 27, 2026
molpopgen
left a comment
molpopgen
left a comment
Member
There was a problem hiding this comment.
Some of these are optional -- perhaps fewer enum variants is good?
|
|
||
| #[non_exhaustive] | ||
| #[derive(Debug)] | ||
| pub enum FromTreeSequenceError { |
Member
There was a problem hiding this comment.
All of the fns are try_from, so do we want the enum name to reflect that? The name is a bit long....
Collaborator
Author
There was a problem hiding this comment.
I think it's implied by "error" that we "tried".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137.