Add collection name and id to opds import log messages for easier deb… #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernstein
force-pushed
the
improve-logging-for-opds-importers
branch
from
bbbf56c to
5844be0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 452 452
Lines 42361 42361
Branches 5921 5921
=======================================
Hits 39255 39255
Misses 2026 2026
Partials 1080 1080 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tdilauro
approved these changes
Oct 28, 2025
| # 4. Make sure that the failure is covered | ||
| assert ( | ||
| "Failed to import publication: urn:isbn:9781234567897 (None) - Error validating publication: 2 validation errors" | ||
| f"Failed to import publication: urn:isbn:9781234567897 (None) for collection '{collection.name}' (id={collection.id}) - Error validating publication: 2 validation errors" |
There was a problem hiding this comment.
Minor: Maybe split the string on this one across a few lines for readability?
dbernstein
force-pushed
the
improve-logging-for-opds-importers
branch
from
5844be0 to
b4ab5aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ugging.
Description
Having the collection name in import log messages is helpful for parsing logs.
Motivation and Context
How Has This Been Tested?
Checklist