Conversation
| g_testApp.close_session(g_testApp.m_windowApp); | ||
|
|
||
| OSP_LOG_INFO("Closed Magnum Application"); | ||
| std::exit(0); |
There was a problem hiding this comment.
i'm fairly certain we would want to keep the behavior of a "graceful" exit.
if that's not working, we should debug why and get it fixed.
There was a problem hiding this comment.
I think this was for debugging something. Will remove.
There was a problem hiding this comment.
Hm, if I remove it and close the window it doesn't stop the application. So I think exiting here is more expected behavior.
There was a problem hiding this comment.
closing the window isn't supposed to exit the application in the current code.
Arguably that's not really what most people want, but it's what the current code was intended to do.
src/testapp/scenarios.cpp
Outdated
| auto const defaultPkg = rTestApp.m_defaultPkg; | ||
| auto const application = rTestApp.m_application; | ||
| auto & rTopData = rTestApp.m_topData; |
There was a problem hiding this comment.
It's a little rough maintaining style without automation to do it.
For now while working on the PR I'll rely on automated formatting of my editor to not go insane. If needed I'll update formatting when this is somewhat ready.
|
Note that the newton dynamics physics engine is very likely to be replaced with Jolt in the very near future, and there's a big change about to be submitted for planet rendering / generation |
Is that merged already? Then I'll rebase. Might have some time today to continue working on this. |
not quite yet, but should be very soon. |
* Move the scenario (involved moving some things into dedicated files like magnum.*) * Rebase to main
|
Jolt physics PR was just merged, planet code change is likely to be merged in the next day or so. (That'll be CapitalAsterix to merge it, probably) |
2 participants
Tracking my WIP progress on a lander game mode in the test app.