[enhancement] Improved NTSD test datasets for massive coverage#40
Merged
p0dalirius merged 5 commits intomainfrom Mar 13, 2026
Merged
[enhancement] Improved NTSD test datasets for massive coverage#40p0dalirius merged 5 commits intomainfrom
p0dalirius merged 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds dataset-generation scripts and updates the NT security descriptor involution test to consume embedded JSON datasets, aiming to greatly expand real-world coverage.
Changes:
- Added PowerShell scripts to dump AD SIDs, AD security descriptors, and local filesystem ACL security descriptors into JSON.
- Embedded
securitydescriptor/tests/datasetsand updatedTestNtSecurityDescriptor_Involutionto iterate over all dataset JSON entries.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
sid/tests/scripts/Dump-ActiveDirectorySids.ps1 |
New script to enumerate AD objectSid values into JSON. |
securitydescriptor/tests/scripts/Dump-LocalFileSystemAcls.ps1 |
New script to recurse filesystem and dump security descriptors into JSON. |
securitydescriptor/tests/scripts/Dump-ActiveDirectoryAcls.ps1 |
New script to dump AD nTSecurityDescriptor into JSON. |
securitydescriptor/NtSecurityDescriptor_test.go |
Updated involution test to read embedded datasets and run roundtrip checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| OSVersionString = $os.VersionString | ||
| } | ||
| } | ||
| ActiveDirectory = @() |
Comment on lines
+34
to
+41
| $roots = @("C:\") | ||
|
|
||
| foreach ($root in $roots) { | ||
| Get-ChildItem -Path $root -Recurse -Force -ErrorAction SilentlyContinue | | ||
| ForEach-Object { | ||
| try { | ||
| Write-Host $_.FullName | ||
| $acl = Get-Acl -LiteralPath $_.FullName |
Comment on lines
+50
to
+58
| # Full SD (Owner, Group, DACL, SACL) | ||
| $searcher.SecurityMasks = | ||
| [System.DirectoryServices.SecurityMasks]::Owner ` | ||
| -bor [System.DirectoryServices.SecurityMasks]::Group ` | ||
| -bor [System.DirectoryServices.SecurityMasks]::Dacl ` | ||
| -bor [System.DirectoryServices.SecurityMasks]::Sacl | ||
|
|
||
| foreach ($res in $searcher.FindAll()) { | ||
|
|
Comment on lines
+76
to
+82
| for _, v := range raw { | ||
| var candidate []descriptorEntry | ||
| if err := json.Unmarshal(v, &candidate); err == nil && len(candidate) > 0 { | ||
| descriptors = candidate | ||
| break | ||
| } | ||
| } |
| } | ||
| } | ||
| if descriptors == nil { | ||
| continue |
Comment on lines
+87
to
+90
| for _, tt := range descriptors { | ||
| tt := tt | ||
| t.Run(datasetName+"/"+componentName+"/"+tt.Name, func(t *testing.T) { | ||
| hexdata := tt.Hexdata |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.