fix: add bounds check to prevent out-of-range access in sparse table #2963
Conversation
Fruitchan5
requested review from
Panquesito7 and
realstealthninja
as code owners
| int p = logs[end - beg + 1]; | ||
| int pLen = 1 << p; | ||
| if (p >= (int)table.size() || beg >= (int)table[p].size() || (end - pLen + 1) >= (int)table[p].size()) { | ||
| std::cerr << "Error: index out of bounds when accessing sparse table." << std::endl; |
There was a problem hiding this comment.
throw an error instead
| int getMinimum(int beg, int end, const std::vector<T>& logs, | ||
| const std::vector<std::vector<T> >& table) { | ||
| if(beg<0||end<<beg||end>=(int)table[0].size()){ | ||
| cout<<"Error:querry range ["<<beg<<","<<end<<"] is invalid."<<endl; |
There was a problem hiding this comment.
| cout<<"Error:querry range ["<<beg<<","<<end<<"] is invalid."<<endl; | |
| throw std::invalid_argument("Error:query range ["<<beg<<","<<end<<"] is invalid."); |
There was a problem hiding this comment.
we can also force beg > 0 by using unsigned integer instead preferably uint32_t
| template <typename T> | ||
| int getMinimum(int beg, int end, const std::vector<T>& logs, | ||
| const std::vector<std::vector<T> >& table) { | ||
| if(beg<0||end<<beg||end>=(int)table[0].size()){ |
There was a problem hiding this comment.
also why are we left shifting end by beg?
shouldnt it be
| if(beg<0||end<<beg||end>=(int)table[0].size()){ | |
| if(beg < 0 || end < beg || end >= (int) table[0].size()){ |
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
4 participants
Description of Change
Fix the out-of-bounds access in `getMinimum()` function in `sparse_table_range_queries.cpp`.Added a boundary check to ensure stable behavior for invalid range queries.
Checklist
Notes:
This fix prevents crashes due to out-of-bounds access in RMQ function.