Added code to update grafana dashboards on monitoring-integration start #576
Conversation
anmolsachan
force-pushed
the
B1_update
branch
from
5fe3b74 to
e48acde
Compare
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=========================================
Coverage ? 44.95%
=========================================
Files ? 40
Lines ? 2307
Branches ? 346
=========================================
Hits ? 1037
Misses ? 1217
Partials ? 53
Continue to review full report at Codecov.
|
Signed-off-by: Anmol Sachan <[email protected]>
anmolsachan
force-pushed
the
B1_update
branch
from
e48acde to
ae00c4a
Compare
| title.append(dashboard_json["uri"].split('/')[1]) | ||
|
|
||
| for dashboard_json in NS.config.data["dashboards"]: | ||
| if dashboard_json in title: |
There was a problem hiding this comment.
This if condition is checking two completely different things:
["cluster-dashboard", "brick-dashboard", "host-dashboard", "volume-dashboard"] &
['tendrl-gluster-at-a-glance', 'tendrl-gluster-hosts', 'tendrl-gluster-volumes', 'tendrl-gluster-bricks']
But its not failing as we are going down straight to creating the dashboard again. The dashboards cannot get updated as the grafana rejects the request with : {u'status': u'name-exists', u'message': u'A dashboard with the same name already exists'} .
| dashboard = dashboard_json["uri"].split('/')[1] | ||
| title.append(dashboard) | ||
| # Deleting already existing dashboards if present | ||
| response = dashboard_utils.delete_dashboard(dashboard) |
There was a problem hiding this comment.
We don't want to delete all dashboards in every sync. I think we need to find a better way of handling this situation.
We need to see if there is an intersection/difference between the two files then only we need to update it. Otherwise, the will keep refreshing the dashboards and can cause a problem(while a user is at a particular dashboard) also it increases the number of calls on the server.
There was a problem hiding this comment.
@cloudbehl agreed, will see to it.
|
@anmolsachan can you attach Bugzilla to this issue |
We dont have one right now, this might go in an update later, will do it when we get a go on this. |
2 participants
Signed-off-by: Anmol Sachan [email protected]