fix(memory-proxy): allow members to select team-visible agents - #930
Draft
guomengjia618-dot wants to merge 1 commit into
Draft
Conversation
Signed-off-by: guomengjia618-dot <guomengjia618@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibility="team".Root cause
CodeBuddy session initialization passed the current user ID to
MetadataClient.listAgents, which added anowner_user_idfilter to the team query. Team-visible agents created by an admin or another member were therefore omitted, causing session initialization and downstream memory injection to be bypassed.Impact
Team members can now select shared agents during CodeBuddy session initialization without gaining access to another member's private agents.
Testing
npm testinMemoryProxyFixes #924