feat(Swiper): add boolean type to navigation api and optimize code
#2060
+255
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSS1102
requested review from
anlyyao,
liweijie0812 and
novlan1
as code owners
commit: |
Contributor
|
|
Collaborator
|
@RSS1102 流水线挂了 |
Collaborator
Author
收到，我看下。 |
RSS1102
changed the title
boolean type support for navigation apiboolean type to navigation api and optimize code
anlyyao
reviewed
Dec 8, 2025
Collaborator
Author
|
/update-snapshot |
Contributor
|
⏳ 正在运行快照更新。。。 CI: Open |
RSS1102
force-pushed
the
rss1102/feat/navigation/boolean
branch
from
1e67c3e to
fb0bd0b
Compare
anlyyao
reviewed
Dec 9, 2025
| if (!props.navigation) return false; | ||
|
|
||
| // navigation 为对象时，检查 minShowNum 配置 | ||
| if (typeof props.navigation === 'object') { |
Collaborator
There was a problem hiding this comment.
props.navigation === true 也要进这个条件吧
Collaborator
Author
There was a problem hiding this comment.
如果显示声明 props.navigation=false 那他应该就是要禁止导航器吧
Collaborator
|
@RSS1102 showControls 的示例，改一下配置 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat(Swiper):
navigation属性扩展支持boolean类型本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单