command: Fix WiFi scan result failed in controller - #127
Open
ian77chen wants to merge 1 commit into
Open
Conversation
skip HaLow phys and harden the scan loop The morse driver advertises unscannable 5G frequencies, so wifiscan hung or aborted on devices with a HaLow radio. Detect morse phys via debugfs (as renderer/wifi/phy.uc does) and skip them. Also fixes faults exposed along the way: 'fs' was re-required inside the module and shadowed cmd.uc's injected copy with null; split_wiphy_dump fragments without a wiphy index were dereferenced; scan_trigger() die()'d on a single failing radio and left a stale 'scan' interface behind; bandwidth was compared against a string-keyed table, letting ch_width fall through to an invalid key and making intersect() iterate over null. Fixes: WIFI-15235 Signed-off-by: Ian Chen <ian77_chen@accton.com>
ian77chen
force-pushed
the
staging-WIFI-15235-fix-wifi-scan
branch
from
August 6, 2026 09:13
772d025 to
1a13060
Compare
SebastianHuang-ec
approved these changes
Aug 6, 2026
SebastianHuang-ec
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip HaLow phys and harden the scan loop
The morse driver advertises unscannable 5G frequencies, so wifiscan hung or aborted on devices with a HaLow radio. Detect morse phys via debugfs (as renderer/wifi/phy.uc does) and skip them.
and redeclaring it made it null, so every fs call threw.
phy.wiphy on those threw.
also left a 'scan' interface behind, which then broke every later run.
never matched and ch_width ended up invalid, making intersect() loop
over nothing.
Fixes: WIFI-15235