Removed tableViewCell property from custom UIScrollView, now uses its superview#8
Open
aout wants to merge 1 commit into
Open
Removed tableViewCell property from custom UIScrollView, now uses its superview#8aout wants to merge 1 commit into
aout wants to merge 1 commit into
Conversation
…f.superview for subclassing purposes
Contributor
|
Yeah, I don't know. What about having the property is bad? I mean, I don't like to rely on the view hierarchy implicitly. |
Author
|
I think it's just a matter of situation. I didn't find any solution with a subclass and multiple XiBs for quick prototyping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any subclass would override the content view, leaving the custom scroll view with a nil ptr.
I guess this is less flexible but we could even nest the custom scroll view inside the cell itself to make it opaque for the end user.