docs: add Chinerey Ukwu to participants list #2534
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daaimah123
approved these changes
Oct 23, 2025
Collaborator
There was a problem hiding this comment.
Great job practicing! 💃🏾 This PR is ready to merge (hit the green button).
A side note, it looks like your PR description contains a lot of information from the template, in the future remove the template placeholder information and check the preview tab before hitting your submit button to ensure the formatting is the way intended. For example, your description should likely look like this with the edits described:
📝 Description:
Adds my name to practice/participants.md as part of the PR review practice exercise. No functional code changes.
🔂 Changes Made:
Edited practice/participants.md to append my name to the list of participants.
⚙️ Related Issue
- Issue Number: # N/A
🍏 Type of Change:
Documentation update
🎁 Acceptance Criteria
- Criterion 1: My name appears at the end of practice/participants.md.
- Criterion 2: Markdown renders correctly as a bullet item.
- Criterion 3: No other files or lines are unintentionally changed.
🧪 How to test or what to evaluate
- Open practice/participants.md.
- Scroll to the bottom and confirm a new bullet: - Chinerey Ukwu.
- Verify that only one line was added (see “Files changed” tab).
- Confirm Markdown preview shows the bullet correctly (optional).
🚀 Repo Notes (if applicable)
- Will the table of contents need to be updated? NONE
- Which other repo areas will be impacted? NONE
- Are there any full time program curriculum considerations? (i.e. day docs, links, introduction of new concepts, etc) NONE
📸 Screenshots (if applicable):
N/A (text-only change)
✅ Checklist
- I have performed a self-review of my code.
- My code follows the style guidelines of this project.
- I have commented my code where necessary.
- I have tested my code locally and verified the website is working as expected.
- (if applicable) I have added documentation in the README.
- (if applicable) I have added tests that prove my fix is effective or that my feature works.
- (if applicable) New and existing unit tests pass locally with my changes.
Author
|
Thank you so much for your response — I really appreciate you taking the
time to reach out. I actually went looking for this message in Slack when I
saw the email and noticed it wasn’t posted there. It would have been nice
to see it shared in the cohort Slack, so others could also see the good
work I did and maybe learn from it for their own practice.
I’m feeling refreshed after getting a good night’s rest, and I’m diving
back into my weekly tasks so I can stay on track and keep the momentum
going.
Thanks again for your support and for keeping us updated!
Best,
*Chinerey Ukwu*
…On Thu, Oct 23, 2025 at 7:13 AM Daaimah Tibrey ***@***.***> wrote:
***@***.**** approved this pull request.
Great job practicing! 💃🏾 This PR is ready to merge (hit the green
button).
A side note, it looks like your PR description contains a lot of
information from the template, in the future remove the template
placeholder information and check the preview tab before hitting your
submit button to ensure the formatting is the way intended. For example,
your description should likely look like this with the edits described:
📝 Description:
Adds my name to practice/participants.md as part of the PR review practice
exercise. No functional code changes.
🔂 Changes Made:
Edited practice/participants.md to append my name to the list of
participants.
⚙️ Related Issue
- Issue Number: # N/A
🍏 Type of Change:
Documentation update
🎁 Acceptance Criteria
- Criterion 1: My name appears at the end of practice/participants.md.
- Criterion 2: Markdown renders correctly as a bullet item.
- Criterion 3: No other files or lines are unintentionally changed.
🧪 How to test or what to evaluate
- Open practice/participants.md.
- Scroll to the bottom and confirm a new bullet: - Chinerey Ukwu.
- Verify that only one line was added (see “Files changed” tab).
- Confirm Markdown preview shows the bullet correctly (optional).
🚀 Repo Notes (if applicable)
- Will the table of contents need to be updated? NONE
- Which other repo areas will be impacted? NONE
- Are there any full time program curriculum considerations? (i.e. day
docs, links, introduction of new concepts, etc) NONE
📸 Screenshots (if applicable):
N/A (text-only change)
✅ Checklist
- I have performed a self-review of my code.
- My code follows the style guidelines of this project.
- I have commented my code where necessary.
- I have tested my code locally and verified the website is working as
expected.
- (if applicable) I have added documentation in the README.
- (if applicable) I have added tests that prove my fix is effective or
that my feature works.
- (if applicable) New and existing unit tests pass locally with my
changes.
—
Reply to this email directly, view it on GitHub
<#2534 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXFVDEOKQ36ROK432B3BTET3ZDPBJAVCNFSM6AAAAACJ66C46CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNZQGE2TGOBVGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Collaborator
|
@uchinerey-gift the email you saw was a notification with details about a comment I left on your GitHub PR. I left a review of the work that you shared in your curriculum PR, please click into the email so you can view your PR and the feedback directly left on the GitHub platform. Your PR feedback will always be left directly in the PR. To be clear, this is not a community message but rather a space to evaluate and communicate about the work on your PR. This is known as the PR feedback iteration process. I can share that with the cohort so that it’s clear for all. Please MERGE your PR, today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description: Adds my name to practice/participants.md as part of the PR review practice exercise. No functional code changes.
Please include a summary of the changes and the related issues.
🔂 Changes Made: Edited practice/participants.md to append my name to the list of participants.
Detail what changes this pull request has and to which areas of the codebase.
⚙️ Related Issue
🍏 Type of Change: Documentation update
🎁 Acceptance Criteria
🧪 How to test or what to evaluate
Please describe the steps on how to test this PR.
🚀 Repo Notes (if applicable)
📸 Screenshots (if applicable): N/A (text-only change)
Add relevant screenshots to explain visual changes.
✅ Checklist