Use env bash to make script more portable #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems might not have the `/bin/bash` link, they might just have a `/bin/sh` that detects whether to run `sh` or `bash` automatically. One example of this is NixOS, or the BSDs. Instead you can rely on the `env` utility to figure out where `bash` is, using the user's `PATH`. `env` will look into all the available paths and use the first path that matches the binary you're looking for, which should make this script more portable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems might not have the
/bin/bashlink, they might just have a/bin/shthat detects whether to runshorbashautomatically. One example of this is NixOS, or the BSDs.Instead you can rely on the
envutility to figure out wherebashis, using the user'sPATH.envwill look into all the available paths and use the first path that matches the binary you're looking for, which should make this script more portable.