Vehicle destroyed event and db log update#396
Open
CamperNoob wants to merge 23 commits intoTeam-Silver-Sphere:masterfrom
Open
Vehicle destroyed event and db log update#396CamperNoob wants to merge 23 commits intoTeam-Silver-Sphere:masterfrom
CamperNoob wants to merge 23 commits intoTeam-Silver-Sphere:masterfrom
Conversation
Finished with logic, filling up the lookups
Add more, enclose in quotes for abc-123 cases
ADF, BAF, CAF, USA, USMC = BLUFOR PLA, PLANMC, PLAAGF = PAC RGF, RAF = RUS MEA, TLF, INS, IMF, WPMC - left as is
Finished with the list
Added missed INS in rhib logi and transport
Added 'Side' lookup
…ted from player 'Side' and vehicle 'Sides'
Added all available in SDK vehicles (some may be just referring to turret). Sorted alphabetically.
remove plugin used for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLAYER_POSSESS_SOLDIERevent to determine player's team (extension ofPLAYER_POSSESS, writes team data toplayer.teamName). Useslookup\soldier-lookup.jsto translate filenames into more consistent team names.VEHICLE_DAMAGEDevent on a new squad log record type (from update that added destroyed vehicles counter in scoreboards) and extensionVEHICLE_DESTROYED. Useslog-parser\lookup\vehicles-lookup.jsto determine vehicle teams.dblog_VehicleDestroystable inplugins\db-log.jswhich storesVEHICLE_DESTROYEDevents afterteamkillcalculation (done withplugins\lookup\factions-lookup.jsto improve confidence ofteamkill).plugins\socket-io-api.jsto include all new event types:VEHICLE_DAMAGED,VEHICLE_DESTROYED,PLAYER_POSSESS_SOLDIER.Known issues:
teamkillis not determined correctly 100% time - issue exists because of how the log record is structured - it includes attacker info and vehicle file name only. The only sensible way to determineteamkill- store teamName fromplayer_possess_soldier, since all soldier model names include the faction name (e.g.BP_Soldier_PLA_Rifleman1.uasset), and compare it to vehicle teamName array (since some vehicles, for example RHIB, appear for multiple factions).log-parser\lookup\vehicles-lookup.jsmay have some incorrect faction assignments, since this information was manually determined according to squad wiki. Vehicle list itself is full (maybe includes a few entries not for vehicle, but it's turret) - according to files present in Squad Editor.teamkill = nullwhen it fails to determine if destroyed vehicle was teamkilled or not (can happen if vehicle is not present in lookup, or player team name was empty for any reason).player.teamNamewill be empty if SquadJS will be started/restarted mid-game (after players were already spawned) and will remain empty until the player exits the vehicle, or respawns.P.S. Branch is open for commits in case locations of lookup files should be changed, or modifications to lookups themselves should be made.