Feat: Support for GC's Player Controllers#345
Open
IgnisAlienus wants to merge 1 commit intoTeam-Silver-Sphere:masterfrom
Open
Feat: Support for GC's Player Controllers#345IgnisAlienus wants to merge 1 commit intoTeam-Silver-Sphere:masterfrom
IgnisAlienus wants to merge 1 commit intoTeam-Silver-Sphere:masterfrom
Conversation
Contributor
|
might be able to just loosen the regex for the player controllers. I don't think they need the current "BP_PlayerContoller_C" and we might just be able to use ".+" instead. |
Contributor
Author
Yeah, that would work just as well if it won't break anything else. |
Collaborator
|
Is there plugins out now that would benefit from this? |
Contributor
Author
|
People that have custom time tracking plugins. I think the other guy my be onto something where the regex on the one is made less specific for the controller. As long as that doesn't break anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for GC's Player Controllers.
I added them in the log-parser as new files instead of messing with and possibly breaking old files.
This may need to be done for any other mods that mess with the BP name for the Player Controller.
Let me know if there's a better way to implement this. But this is working for me on our Server.