fix reconnection handling of CredentialsException #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuckc
force-pushed
the
fix-reconnect-credentials-error
branch
from
8117271 to
e18eb92
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds URI password masking functionality for secure logging. When logging connection information, passwords in URIs are replaced with *** to prevent credentials from appearing in logs.
- Adds
mask_uri()function to mask passwords in URIs for logging - Updates
maintain_qipc_connection()to use masked URIs in log messages and adds araise_bad_credsparameter - Includes unit tests for the new
mask_uri()function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| aiokdb/client.py | Implements mask_uri() function and updates logging in maintain_qipc_connection() to use masked URIs; adds new function parameter |
| test/test_client_server.py | Adds unit tests for the mask_uri() function with various URI formats |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shuckc
force-pushed
the
fix-reconnect-credentials-error
branch
2 times, most recently
from
f6691b6 to
edc0a0c
Compare
shuckc
changed the title
shuckc
changed the title
shuckc
force-pushed
the
fix-reconnect-credentials-error
branch
from
edc0a0c to
f8245c7
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
test/test_client_server.py:257
- Corrected spelling of 'recieved' to 'received'.
print(f"recieved banner {r.aJ()}")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shuckc
force-pushed
the
fix-reconnect-credentials-error
branch
2 times, most recently
from
1d711c2 to
ed0db59
Compare
Add masked URI to reconnection logic INFO messages to help distinguish multiple connections.
shuckc
force-pushed
the
fix-reconnect-credentials-error
branch
from
ed0db59 to
851e0c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #34
Add masked URI to reconnection logic INFO messages to help distinguish multiple connections.