Skip to content

fix: fixed issue where swagger and redoc were not displaying properly if API is rate limited by Blizzard#365

Merged
TeKrop merged 1 commit intomainfrom
bugfix/doc-page-not-displayed-if-429
Feb 18, 2026
Merged

fix: fixed issue where swagger and redoc were not displaying properly if API is rate limited by Blizzard#365
TeKrop merged 1 commit intomainfrom
bugfix/doc-page-not-displayed-if-429

Conversation

@TeKrop
Copy link
Owner

@TeKrop TeKrop commented Feb 18, 2026

Summary by Sourcery

Bug Fixes:

  • Ensure Swagger and Redoc documentation pages render correctly when Blizzard API responses are rate limited.

@TeKrop TeKrop self-assigned this Feb 18, 2026
@TeKrop TeKrop added the bug Something isn't working label Feb 18, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 18, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the NGINX Lua valkey handler used for proxying Blizzard API requests so that Swagger and Redoc documentation continue to render correctly even when upstream responses are rate-limited.

File-Level Changes

Change Details Files
Update the Lua valkey handler logic so that documentation UIs (Swagger/Redoc) are not broken when Blizzard returns rate limit responses.
  • Modify response handling to distinguish between API calls used by Swagger/Redoc and general API traffic when upstream responds with rate limiting status codes
  • Adjust forwarding or transformation of rate-limited responses so that Swagger/Redoc assets and JSON specs still load successfully
  • Possibly refine error/status mapping or headers to avoid breaking the documentation frontend when rate limiting occurs
build/nginx/valkey_handler.lua.template

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud
Copy link

@TeKrop TeKrop merged commit c36c6ee into main Feb 18, 2026
5 checks passed
@TeKrop TeKrop deleted the bugfix/doc-page-not-displayed-if-429 branch February 18, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments