Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-script-preloads.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/router-core': patch
---

Render manifest script preloads with low fetch priority so they do not compete with render-blocking resources.
38 changes: 37 additions & 1 deletion packages/react-router/tests/Scripts.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,35 @@ describe('ssr HeadContent', () => {
)
})

test('renders manifest module preloads with low fetch priority', async () => {
const preloadHref = '/low-priority-module.js'
const rootRoute = createRootRoute({
component: () => <HeadContent />,
})
const indexRoute = createRoute({
path: '/',
getParentRoute: () => rootRoute,
})
const router = createRouter({
history: createMemoryHistory({ initialEntries: ['/'] }),
routeTree: rootRoute.addChildren([indexRoute]),
isServer: true,
})

router.ssr = {
manifest: createTestManifest(rootRoute.id, { preloadHref }),
}

await router.load()

const html = ReactDOMServer.renderToString(
<RouterProvider router={router} />,
)
expect(html).toContain(
`<link rel="modulepreload" href="${preloadHref}" fetchPriority="low"/>`,
)
})

test('keeps manifest stylesheet links mounted when history state changes', async () => {
const history = createTestBrowserHistory()
const stylesheetHref = '/history-state.css'
Expand Down Expand Up @@ -745,7 +774,7 @@ describe('ssr HeadContent', () => {
).toBe('.runtime{color:red}')
})

test('renders preload as script links for iife manifest preloads', async () => {
test('renders iife manifest preloads as low priority script links', async () => {
const history = createTestBrowserHistory()
const preloadHref = '/iife-preload.js'

Expand Down Expand Up @@ -795,6 +824,13 @@ describe('ssr HeadContent', () => {
`link[rel="modulepreload"][href="${preloadHref}"]`,
),
).toBeFalsy()
expect(
document.head
.querySelector(
`link[rel="preload"][as="script"][href="${preloadHref}"]`,
)
?.getAttribute('fetchpriority'),
).toBe('low')
})

test('assetCrossOrigin overrides manifest crossOrigin values', async () => {
Expand Down
2 changes: 2 additions & 0 deletions packages/router-core/src/manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export function getScriptPreloadAttrs(
rel: 'modulepreload' | 'preload'
as?: 'script'
href: string
fetchPriority: 'low'
crossOrigin?: AssetCrossOrigin
} {
const preloadLink = resolveManifestAssetLink(link)
Expand All @@ -54,6 +55,7 @@ export function getScriptPreloadAttrs(
? { rel: 'preload', as: 'script' }
: { rel: 'modulepreload' }),
href: preloadLink.href,
fetchPriority: 'low',
...(crossOrigin ? { crossOrigin } : {}),
}
}
Expand Down
2 changes: 2 additions & 0 deletions packages/vue-router/tests/Scripts.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ describe('ssr HeadContent', () => {
const ssrPreload = document.createElement('link')
ssrPreload.setAttribute('rel', 'modulepreload')
ssrPreload.setAttribute('href', '/main.js')
ssrPreload.setAttribute('fetchpriority', 'low')

document.head.append(ssrStylesheet, ssrPreload)

Expand Down Expand Up @@ -397,6 +398,7 @@ describe('ssr HeadContent', () => {
const ssrPreload = document.createElement('link')
ssrPreload.setAttribute('rel', 'modulepreload')
ssrPreload.setAttribute('href', '/index.js')
ssrPreload.setAttribute('fetchpriority', 'low')

document.head.append(ssrStylesheet, ssrPreload)

Expand Down