Implement auto-registering operators for live queries #944
+2,359
−879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables tree-shaking by having each operator register its own evaluator when imported, rather than relying on a monolithic switch statement. Key changes: - Add registry.ts with registerOperator/getOperatorEvaluator APIs - Create individual operator files (eq, gt, gte, lt, lte, and, or, not, in, like, ilike, upper, lower, length, concat, coalesce, add, subtract, multiply, divide, isNull, isUndefined) - Each operator file bundles builder function + evaluator + registration - Modify evaluators.ts to use registry lookup instead of switch - Update query/index.ts to export from new operator modules - Export compileExpressionInternal for operator modules to use The pattern: importing an operator causes its file to execute, which calls registerOperator, adding it to the registry. By query compile time, all operators in use are already registered.
🦋 Changeset detectedLatest commit: 3440d6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: +6.35 kB (+7.28%) 🔍 Total Size: 93.5 kB
ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.34 kB ℹ️ View Unchanged
|
Export the registry API so users can create and register their own custom operators. Also adds a changeset for this patch.
- Export registerOperator, EvaluatorFactory, and CompiledExpression types - Add comprehensive tests for custom operator registration - Tests cover between, startsWith, isEmpty, modulo operators - Demonstrates full pattern: builder function + evaluator + registration
Extend the auto-registration pattern to aggregates (sum, count, avg, min, max): - Create aggregate-registry.ts with registerAggregate/getAggregateConfig - Split each aggregate into its own module with builder + auto-registration - Update group-by.ts to use registry lookup instead of switch statement - Export registerAggregate and types from public API - Add tests demonstrating custom aggregate registration This enables tree-shaking for aggregates and allows users to register custom aggregates like 'product', 'variance', etc.
- Remove eager imports from evaluators.ts and group-by.ts - Make functions.ts re-export from operator/aggregate modules - Add shared types.ts for type helpers preserving nullability - Update test files to import operators for direct IR testing Now operators/aggregates are only loaded when user imports them, enabling true tree-shaking. The compiler no longer pre-loads all evaluators - they register when their builder functions are imported.
Replace global registry pattern with embedded factories for true tree-shaking: - Func nodes now carry their evaluator factory directly - Aggregate nodes now carry their config (factory + valueTransform) directly - Remove registry.ts and aggregate-registry.ts files - Update all operators to pass factory as 3rd argument to Func - Update all aggregates to pass config as 3rd argument to Aggregate - Update internal code (optimizer, predicate-utils, expressions) to preserve factories when transforming Func nodes - Add array overloads to and() and or() for internal usage - Update tests to use builder functions instead of creating IR directly This design eliminates the need for side-effect imports and ensures only imported operators/aggregates are bundled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables tree-shaking by having each operator register its own evaluator when imported, rather than relying on a monolithic switch statement.
Key changes:
The pattern: importing an operator causes its file to execute, which calls registerOperator, adding it to the registry. By query compile time, all operators in use are already registered.
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact