Handle pushed down predicates in Electric collection #618
+1,279
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9a8721 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kevin-dp
force-pushed
the
kevin/pred-pushdown-to-sync-db
branch
from
aa2e623 to
2ae236f
Compare
kevin-dp
force-pushed
the
kevin/pred-pushdown-to-sync-electric-coll
branch
from
d66c54e to
71cef08
Compare
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
|
Size Change: 0 B Total Size: 76.9 kB ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 1.46 kB ℹ️ View Unchanged
|
kevin-dp
force-pushed
the
kevin/pred-pushdown-to-sync-db
branch
from
91ea051 to
3493f6d
Compare
kevin-dp
force-pushed
the
kevin/pred-pushdown-to-sync-electric-coll
branch
from
49f1f59 to
dd337d8
Compare
samwillis
reviewed
Oct 10, 2025
| clause: IR.OrderByClause, | ||
| params: Array<unknown> | ||
| ): string { | ||
| // TODO: what to do with stringSort and locale? |
There was a problem hiding this comment.
This raises the question on if we have the wrong default in DB, should we default to lexical sort?
Comment on lines
+840
to
+846
| // After receiving Bob and Charlie, the collection now has 3 users (Alice + Bob + Charlie) | ||
| // but it still requests 2 more... TODO: check if this is correct? | ||
| expect(callArgs(1)).toMatchObject({ | ||
| limit: 2, | ||
| orderBy: `age NULLS FIRST`, | ||
| }) | ||
| }) |
There was a problem hiding this comment.
@kevin-dp not sure why it does this
…ests These tests have a known issue with unhandled rejection warnings that exists in the main branch. The test functionality works correctly, but vitest reports unhandled rejections when testing timeout behavior with fake timers. The tests properly validate that timeouts occur and are handled, but the setTimeout callback in awaitMatch creates promise rejections that vitest flags as unhandled, even though they are properly caught by the test assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on #617 and modifies the Electric collection to handle predicates that are being pushed down to the Electric collection.