Skip to content

Conversation

xarvex
Copy link
Member

@xarvex xarvex commented Aug 23, 2025

Summary

Depends: #1047
Fixes: #915
Fixes: #988

Took me some time to completely work this out (and to get sorted from life stuff). The good part is that whatever issues were halting simply using the newer versions of PySide are seemingly no longer there. The wrapping done for Qt was fixed, it was not quite done correctly, which broke using hardware acceleration. Outside of that, this does some general touch ups to get to the state of the current repo.

To hopefully prevent future mismatches between the version of PySide, and therefore Qt, used in the project versus present in nixpkgs, I override where the PySide module from nixpkgs is always used, even in the dev shell. This is a trade-off from sticking to an environment closely resembling ideals, but managing the drift in versions clearly hasn't worked out. It might be worth checking out patching the dynamic library for Qt that PySide loads, but that might still have the issue of PySide's own version.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable
    • Nix package

@xarvex xarvex added Type: Installation Installing, building, and/or launching the program Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed System: Linux For Linux/BSD distributions Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Aug 23, 2025
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well on my system, however I don't have a good testing library so I can't say whether all thumbnail types still work.
(Also the install time is much shorter now, thanks to not compiling qt anymore)

@Computerdores Computerdores moved this to 👀 In review in TagStudio Development Aug 23, 2025
@Computerdores Computerdores moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Aug 23, 2025
@xarvex xarvex removed the Status: Review Needed A review of this is needed label Aug 23, 2025
@xarvex
Copy link
Member Author

xarvex commented Aug 24, 2025

Could have sworn Python 3.12 did not function while doing this, seems to be all good using it for the moment. Will simply adjust back to 3.13 depending on what happens with #1047.

That makes this mergeable.

@xarvex xarvex added Status: Mergeable The code is ready to be merged and removed Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Aug 24, 2025
@xarvex xarvex merged commit 899c534 into main Aug 24, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Aug 24, 2025
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Aug 24, 2025
@CyanVoxel CyanVoxel deleted the nix-qt-fix branch September 28, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last System: Linux For Linux/BSD distributions Type: Installation Installing, building, and/or launching the program
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Nix package fails due to Qt version mismatch [Bug]: TagStudio breaks in nixos-unstable
3 participants