Repository navigation
Fix optimizer checkpoint state round-trip - #15
Open
koriyoshi2041 wants to merge 2 commits into
Open
koriyoshi2041 wants to merge 2 commits into
koriyoshi2041 wants to merge 2 commits into
Conversation
Author
|
Small follow-up after rechecking the current head ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9.
The optimizer wrapper now saves its own perturbation state, wrapper attributes, scheduler state, and the wrapped base optimizer in a versioned checkpoint. Loading keeps compatibility with legacy base-only checkpoints and rebinds the shared parameter groups.
The scheduler follow-up adds explicit phase round-tripping for INFTY schedulers and for the wrapped PyTorch scheduler used by
ProportionScheduler. The resume regression advances both continuous and restored paths and compares the next scheduled value and LookSAM parameter update.Validation:
uv run --frozen --with pytest --with pyyaml pytest -q— 33 passeduv run --frozen --with pytest pytest tests/optim/test_geometry_reshaping.py -q— 4 passedgit diff --checkKnown boundary: runtime closures are deliberately reattached with
set_closure()rather than serialized. The separate LookSAMold_g/old_gradmismatch is not part of this checkpoint fix.