Handle exceptions while writing to files #4400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshiRulz
reviewed
Jul 13, 2025
src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.IToolForm.cs
Outdated
Show resolved
Hide resolved
SuuperW
force-pushed
the
dot_saving
branch
2 times, most recently
from
fde3481 to
0798074
Compare
|
Highlights of force push:
|
This comment was marked as outdated.
This comment was marked as outdated.
SuuperW
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
I believe this is ready for merge. See edited OP for notes on some behavior changes. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Removed ISaveRam refactor. |
YoshiRulz
added
App: EmuHawk
…e until writing has completed. Avoids crashing and prevents loss of data in the event of an exception mid-write.
…still broken on close and on TAStudio open.
…celing flow even though not all asking and error handling is implemented yet. Also, fix: respect the cancel button.
…properly checks the autosave config option.
|
Are there any reasons to not merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most file writes now use a new system that allows for error detection and handling. (includes movies, config file, and all tools)
When an exception occurs, a message box appears alerting the user. If there is an exception while doing a save-on-close, the user is given the option to try again, skip saving, or cancel closing. (Includes a bug fix where an existing dialog offering the cancel option did not actually cancel.)
Addresses #4258.
Fixes an issue where the CheatList was being forcibly autosaved when closing a game, ignoring the autosave config option.
Changes behavior when saving the config file fails. Previously it would silently fail (and report success if "saved" via the menu item), now it has the same error handling as other updated file writes. The silent fail seems to have been intended to allow using a read-only config file. If we want to bring this back, I suggest making a config option to not save on close instead. As-is, a read-only file will still work you just have to click "No" after closing EmuHawk when it tells you it can't save the config file.
Check if completed: