Issue #574, #575: Upgrade to Weaver 2.3.0-SNAPSHOT, Java 25, Spring Boot 3.5.6#576
Issue #574, #575: Upgrade to Weaver 2.3.0-SNAPSHOT, Java 25, Spring Boot 3.5.6#576tamu-sad-iii wants to merge 13 commits intomainfrom
Conversation
Builds and runs but does not show in UI. Work in progress.
…on to 1.4.0-SNAPSHOT
I recommend each instance of the intended all parameters be consistent. I have seen `params`, `parameters`, and `reqFilterMap`.
| public abstract class BasicValueOp extends BasicOp { | ||
|
|
||
| @Column(nullable = true) | ||
| @Column(nullable = true, name = "\"value\"") |
There was a problem hiding this comment.
Its not clear to me why this is done.
The defaults should be fine because it maps to the value name.
There is, however, concerns with the particular database making it uppercase or otherwise transofmring it.
This:
hibernate.globally_quoted_identifiers=true
Seems to be a cleaner, easier to maintain, solution so as to not write all of these name ="\"...\"" everywhere.
Also note that this might need to be configured to:
spring.jpa.properties.hibernate.globally_quoted_identifiers_skip_column_definitions=true
These might be an even better choice so as to avoid having to set the quoting:
spring.jpa.hibernate.naming.implicit-strategy=org.hibernate.boot.model.naming.ImplicitNamingStrategyLegacyJpaImpl
spring.jpa.hibernate.naming.physical-strategy=org.hibernate.boot.model.naming.PhysicalNamingStrategyStandardImpl
I agree with this comment from the end of the last link below:
Although you could automatically quote all identifiers, in reality, it’s much better if you escape only those database objects that include a reserved keyword. This will provide better control than the automatic quoting strategies.
see: https://stackoverflow.com/questions/25283198/spring-boot-jpa-column-name-annotation-ignored
see: https://stackoverflow.com/questions/35697121/jpa-hibernate-camelcase-field/35708531#35708531
see: https://docs.spring.io/spring-boot/docs/1.1.7.RELEASE/reference/htmlsingle/#boot-features-creating-and-dropping-jpa-databases
see: https://vladmihalcea.com/escape-sql-reserved-keywords-jpa-hibernate/
| COPY --from=node /usr/local/bin/ /usr/local/bin/ | ||
| COPY --from=node /usr/local/lib/ /usr/local/lib/ | ||
| COPY --from=node /usr/local/share/ /usr/local/share/ | ||
| COPY --from=node /usr/local/include/ /usr/local/include/ |
Co-authored-by: Kevin Day <35114839+kaladay@users.noreply.github.com>
kaladay
left a comment
There was a problem hiding this comment.
Approved with the stipulation that there are parts that are unclear to me as to why something is done.
These already have comments on them.
This is blocked by TAMULib/Weaver-Webservice-Core#166. Please review the changes there first.
Description
meta.stacktraceto expected responses in controller tests.@RequestParamas single parameter to be explicit.@PathVariableto be explicit.Resolves #574
Resolves #575
How Has This Been Tested?
mvn clean spring-boot:runjava -jar target\ROOT.warmvn clean testdocker-compose build --no-cacheTest Configuration:
Checklist: