feat: CMD-112 custom confirmation e-mail via setting #448

wesleyboar · 2024-03-27T15:57:20Z

Overview

Use Core-CMS confirmation e-mail code.
Overwrite Core-CMS confirmation e-mail content.

Status

Pending different solution via new ticket CMD-140: Make Core-CMS Confirmation E-mail Opt-In
Change CMD-112 to use custom setting, not files.
Release & Pin CMS version.
Do not send email if form is rt-ticket-form.

Changes

added confirmation email overwrite files
removed TUP's confirmation e-mail code

Testing

Remote

Submit two forms:
- https://dev.tup.tacc.utexas.edu/about/tours/request/
- https://dev.tup.tacc.utexas.edu/about/help/
✅ Verify you do receive:
1. E-mail from [email protected]… that says
  
  […] Thank you for contacting TACC Support.
2. E-mail from no-reply@tacc… with message body:
  
  […] Thank you for reaching out to TACC and completing the Tour Request Form.
❌ Verify you do NOT receive:
1. E-mail from no-reply@tacc… with message body:
  
  […] Thank you for reaching out to TACC and completing the rt-ticket-form.

Local

npx nx build tup-cms
npx nx serve tup-cms

Open a CMS form (not /about/help) with an e-mail field (display name is "Email" or "email").
Make sure form would send e-mail e.g.
- edit form and have e-mail address in "Send form data to e-mail address:",
- in /apps/tup-cms/src/taccsite_cms/settings_local.py, set DEFAULT_FROM_EMAIL to an e-mail address.
Submit e-mail address via form.
Verify only one confirmation e-mail (text and html versions) would be received.
Verify that confirmation e-mail has "Business hours …" paragraph.

UI

Remote @ 2024-06

…

Local @ 2024-04

Docker log (for sending email to user)

tup_cms           | [DJANGO] DEBUG 2024-04-01 16:06:38,314 UTC apps portal.common_apps.email_management.apps.callback:40: received submission from Help (Not Via RT)
tup_cms           | [DJANGO] DEBUG 2024-04-01 16:06:38,314 UTC apps portal.common_apps.email_management.apps.callback:41: <class 'dict'>
tup_cms           | [DJANGO] DEBUG 2024-04-01 16:06:38,316 UTC apps portal.apps.portal.apps.callback:46: received submission from Help (Not Via RT)
tup_cms           | Content-Type: multipart/alternative;
tup_cms           |  boundary="===============3785253249513235131=="
tup_cms           | MIME-Version: 1.0
tup_cms           | Subject: TACC Form Submission Received: Help (Not Via RT)
tup_cms           | From: [email protected]
tup_cms           | To: [email protected]
tup_cms           | Date: Mon, 01 Apr 2024 21:06:38 -0000
tup_cms           | Message-ID: <171200559831.9.11548662848347038720@tup_cms>
tup_cms           | 
tup_cms           | --===============3785253249513235131==
tup_cms           | Content-Type: text/plain; charset="utf-8"
tup_cms           | MIME-Version: 1.0
tup_cms           | Content-Transfer-Encoding: 7bit
tup_cms           | 
tup_cms           | 
tup_cms           | Greetings,
tup_cms           | 
tup_cms           | You have successfully submitted a form on the TUP CMS website. Thank you for your submission.
tup_cms           | 
tup_cms           | Business hours are Monday - Friday, 8AM to 5PM Central. We will respond to your submission according to the information provided on the form webpage.
tup_cms           | 
tup_cms           | Sincerely,
tup_cms           | TUP CMS Communications
tup_cms           | 
tup_cms           | --===============3785253249513235131==
tup_cms           | Content-Type: text/html; charset="utf-8"
tup_cms           | MIME-Version: 1.0
tup_cms           | Content-Transfer-Encoding: 7bit
tup_cms           | 
tup_cms           | 
tup_cms           | <p>Greetings,</p>
tup_cms           | <p>
tup_cms           |   You have successfully submitted a form on the TUP CMS website. Thank you for your submission.
tup_cms           | </p>
tup_cms           | <p>
tup_cms           |   Business hours are Monday - Friday, 8AM to 5PM Central. We will respond to your submission according to the information provided on the form webpage.
tup_cms           | </p>
tup_cms           | <p>
tup_cms           |   Sincerely,<br />
tup_cms           |   TUP CMS Communications
tup_cms           | </p>
tup_cms           | 
tup_cms           | --===============3785253249513235131==--
tup_cms           | 
tup_cms           | -------------------------------------------------------------------------------

Docker log (for sending email to TACC)

tup_cms           | [DJANGO] INFO 2024-04-01 16:06:31,292 UTC basehttp django.server.log_message:212: "GET /core/markup/nav/ HTTP/1.1" 200 1218
tup_cms           | Content-Type: multipart/alternative;
tup_cms           |  boundary="===============1556261318995665495=="
tup_cms           | MIME-Version: 1.0
tup_cms           | Subject: Form Submission - Help (Not Via RT)
tup_cms           | From: webmaster@localhost
tup_cms           | To: [email protected]
tup_cms           | Date: Mon, 01 Apr 2024 21:06:38 -0000
tup_cms           | Message-ID: <171200559831.9.680013331273973475@tup_cms>
tup_cms           | 
tup_cms           | --===============1556261318995665495==
tup_cms           | Content-Type: text/plain; charset="utf-8"
tup_cms           | MIME-Version: 1.0
tup_cms           | Content-Transfer-Encoding: 7bit
tup_cms           | 
tup_cms           | 
tup_cms           | 
tup_cms           | Form: Help (Not Via RT)
tup_cms           | Date: 1st April 2024 16:06
tup_cms           | 
tup_cms           | 
tup_cms           | Name:
tup_cms           | Once More
tup_cms           | 
tup_cms           | Email:
tup_cms           | [email protected]
tup_cms           | 
tup_cms           | 
tup_cms           | Sent via http://localhost:8000
tup_cms           | 
tup_cms           | --===============1556261318995665495==
tup_cms           | Content-Type: text/html; charset="utf-8"
tup_cms           | MIME-Version: 1.0
tup_cms           | Content-Transfer-Encoding: 7bit
tup_cms           | 
tup_cms           | <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
tup_cms           | <html xmlns="http://www.w3.org/1999/xhtml">
tup_cms           |     <head>
tup_cms           |         <meta name="viewport" content="width=device-width" />
tup_cms           |         <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
tup_cms           |         <title>Form Submission - Help (Not Via RT)</title>
tup_cms           |     </head>
tup_cms           |     <body itemscope itemtype="http://schema.org/EmailMessage">
tup_cms           |         <h1></h1>
tup_cms           |         <p><strong>Date:</strong> 1st April 2024 16:06</p>
tup_cms           |         
tup_cms           |             <p>
tup_cms           |                 <strong>Name:</strong><br/>
tup_cms           |                 Once More
tup_cms           |             </p>
tup_cms           |         
tup_cms           |             <p>
tup_cms           |                 <strong>Email:</strong><br/>
tup_cms           |                 [email protected]
tup_cms           |             </p>
tup_cms           |         
tup_cms           |         Sent via <a href="http://localhost:8000/about/help-not-via-rt/">localhost:8000/about/help-not-via-rt/</a>
tup_cms           |     </body>
tup_cms           | </html>
tup_cms           | 
tup_cms           | --===============1556261318995665495==--
tup_cms           | 
tup_cms           | -------------------------------------------------------------------------------

wesleyboar · 2024-03-28T21:36:15Z

@jarosenb reviewed privately. Results are:

apps/tup-cms/docker-compose.dev.yml

wesleyboar

Tweaks

apps/tup-cms/src/taccsite_cms/settings_custom.py

TACC/Core-CMS#829

cuz the content is html… so why not

wesleyboar

Not ready to merge. Introduces regression bug.

wesleyboar · 2024-07-11T00:49:55Z

apps/tup-cms/src/apps/portal/apps.py

    if form.name == 'rt-ticket-form':
        submit_ticket(cleaned_data)
-    elif ('email' in cleaned_data):
-        send_confirmation_email(form.name, cleaned_data)


Caution
REGRESSION BUG: Yes, Core-CMS will send_confirmation_email instead. But TACC should not send_confirmation_email if ticket is an rt-ticket-form. Core-CMS does not know this, so TACC will send_confirmation_email for rt-ticket-form.

test: CMD-112 overwrite confirmation e-mail

6477843

wesleyboar mentioned this pull request Mar 27, 2024

CMD-112 Let Client CMS Overwrite Core-CMS Confirmation Email TACC/Core-CMS#826

Merged

wesleyboar added 2 commits March 27, 2024 11:29

chore: npx nx format:write

17d00ad

test: cmd-112 verbose way to get core email_… app

38275b6

wesleyboar requested a review from jarosenb March 28, 2024 00:11

wesleyboar marked this pull request as ready for review March 28, 2024 00:15

fix: cmd-112 it works now (plan A)

32c4cff

wesleyboar marked this pull request as draft March 28, 2024 21:34

wesleyboar commented Mar 29, 2024

View reviewed changes

apps/tup-cms/docker-compose.dev.yml Outdated Show resolved Hide resolved

wesleyboar removed the request for review from jarosenb March 29, 2024 15:26

This was referenced Mar 29, 2024

refactor: CMD-141 move email_management app TACC/Core-CMS#828

Merged

CMD-140: Make Core-CMS Confirmation E-mail Opt-In Setting TACC/Core-CMS#827

Merged

refactor: cmd-112 no need to change docker-compose

3d9d282

wesleyboar marked this pull request as ready for review April 1, 2024 20:24

wesleyboar commented Apr 1, 2024

View reviewed changes

apps/tup-cms/src/taccsite_cms/settings_custom.py Outdated Show resolved Hide resolved

apps/tup-cms/src/taccsite_cms/settings_custom.py Outdated Show resolved Hide resolved

wesleyboar added 2 commits April 1, 2024 15:47

refactor: cmd-112

9c7007f

TACC/Core-CMS#829

chore: cmd-112 via core-cms v4.10.1

f13eaf7

wesleyboar requested a review from jarosenb April 1, 2024 21:08

wesleyboar changed the title ~~test: CMD-112 overwrite confirmation e-mail~~ feat: CMD-112 overwrite confirmation e-mail Apr 1, 2024

wesleyboar and others added 2 commits April 1, 2024 16:10

chore: cmd-112 remove outdated files

4bb980f

Merge branch 'main' into test/CMD-112-override-confirmation-email

c48bfce

wesleyboar changed the title ~~feat: CMD-112 overwrite confirmation e-mail~~ feat: CMD-112 send custom confirmation e-mail via setting Jul 10, 2024

wesleyboar added 5 commits July 10, 2024 16:50

Merge branch 'main' into test/CMD-112-override-confirmation-email

e780f44

fix: update settings_custom.py with latest e-mail

0807751

fix: use mailto link for email

3fb8559

cuz the content is html… so why not

fix: use mailto link for all emails

ecff05e

fix: update text-format e-mail

c66927f

This was referenced Jul 10, 2024

feat: CMD-112 form_name in custom email message TACC/Core-CMS#846

Merged

feat: CMD-112 form_name in custom email message — off v4.10.2 TACC/Core-CMS#847

Merged

test(tup-cms): form_name support from CMS

c54aa75

wesleyboar changed the title ~~feat: CMD-112 send custom confirmation e-mail via setting~~ feat: CMD-112 custom confirmation e-mail via setting Jul 10, 2024

feat(tup-cms): form_name via v4.10.2-extra.1

fbf6ee9

wesleyboar marked this pull request as draft July 11, 2024 00:38

wesleyboar commented Jul 11, 2024

View reviewed changes

wesleyboar removed the request for review from jarosenb July 11, 2024 00:50

wesleyboar mentioned this pull request Sep 10, 2024

feat: update Core-CMS & Core-Styles, rename CMS Settings, Portal Purple to Blue #476

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: CMD-112 custom confirmation e-mail via setting #448

feat: CMD-112 custom confirmation e-mail via setting #448

Uh oh!

wesleyboar commented Mar 27, 2024 •

edited

Loading

Uh oh!

wesleyboar commented Mar 28, 2024

Uh oh!

Uh oh!

wesleyboar left a comment

Uh oh!

Uh oh!

Uh oh!

wesleyboar left a comment •

edited

Loading

Uh oh!

wesleyboar Jul 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: CMD-112 custom confirmation e-mail via setting #448

Are you sure you want to change the base?

feat: CMD-112 custom confirmation e-mail via setting #448

Uh oh!

Conversation

wesleyboar commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Status

Related

Changes

Testing

Remote

Local

UI

Remote @ 2024-06

Local @ 2024-04

Uh oh!

wesleyboar commented Mar 28, 2024

Uh oh!

Uh oh!

wesleyboar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wesleyboar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wesleyboar Jul 11, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wesleyboar commented Mar 27, 2024 •

edited

Loading

wesleyboar left a comment •

edited

Loading