ST6RI-909 Circular recursive import causes infinite recursion in getImportedMembership #729
+31
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug that caused an infinite recursion in the computation of imported memberships in a model with a circular recursive import. For example, with the model
calling
getImportedMembershipon the elementTest::Presulted in aStackOverflowError.The bug was corrected by updating
MembershipImportAdapter::importMembershipsto properly check whether theimportedElementwas in theexcludedset before recursing. (Note that a similar check was already proper implemented inNamspaceImportAdapter::importMemberships.)