- 
                Notifications
    You must be signed in to change notification settings 
- Fork 22
Added config validation #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bocharsky-bw
  merged 6 commits into
  SymfonyCasts:main
from
evertharmeling:config-validation
  
      
      
   
  Nov 17, 2023 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            6 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      de3d681
              
                Added check for unique filenames in sass-paths
              
              
                evertharmeling b2c9eaa
              
                Added test for bundle configuration
              
              
                evertharmeling e824d26
              
                Added phpstan-symfony to prevent new errors and simplify config
              
              
                evertharmeling d3f0684
              
                Updated phpstan level to 5
              
              
                evertharmeling d82f703
              
                Fix php-cs-fixer errors
              
              
                evertharmeling 53cc09d
              
                Update error message
              
              
                evertharmeling File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,10 +1,7 @@ | ||
| includes: | ||
| - vendor/phpstan/phpstan-symfony/extension.neon | ||
|  | ||
| parameters: | ||
| level: 4 | ||
| level: 5 | ||
| paths: | ||
| - src | ||
|  | ||
| ignoreErrors: | ||
| - | ||
| message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeParentInterface\\:\\:defaultValue\\(\\)\\.$#" | ||
| count: 1 | ||
| path: src/DependencyInjection/SymfonycastsSassExtension.php | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <?php | ||
|  | ||
| declare(strict_types=1); | ||
|  | ||
| /* | ||
| * This file is part of the SymfonyCasts SassBundle package. | ||
| * Copyright (c) SymfonyCasts <https://symfonycasts.com/> | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|  | ||
| namespace Symfonycasts\SassBundle\Tests; | ||
|  | ||
| use Matthias\SymfonyConfigTest\PhpUnit\ConfigurationTestCaseTrait; | ||
| use PHPUnit\Framework\TestCase; | ||
| use Symfonycasts\SassBundle\DependencyInjection\SymfonycastsSassExtension; | ||
|  | ||
| final class ConfigurationTest extends TestCase | ||
| { | ||
| use ConfigurationTestCaseTrait; | ||
|  | ||
| protected function getConfiguration(): SymfonycastsSassExtension | ||
| { | ||
| return new SymfonycastsSassExtension(); | ||
| } | ||
|  | ||
| public function testSingleSassRootPath(): void | ||
| { | ||
| $this->assertConfigurationIsValid([ | ||
| 'symfonycasts_sass' => [ | ||
| 'root_sass' => [ | ||
| '%kernel.project_dir%/assets/scss/app.scss', | ||
| ], | ||
| ], | ||
| ]); | ||
| } | ||
|  | ||
| public function testMultipleSassRootPaths(): void | ||
| { | ||
| $this->assertConfigurationIsValid([ | ||
| 'symfonycasts_sass' => [ | ||
| 'root_sass' => [ | ||
| '%kernel.project_dir%/assets/scss/app.scss', | ||
| '%kernel.project_dir%/assets/admin/scss/admin.scss', | ||
| ], | ||
| ], | ||
| ]); | ||
| } | ||
|  | ||
| public function testMultipleSassRootPathsWithSameFilename(): void | ||
| { | ||
| $this->assertConfigurationIsInvalid([ | ||
| 'symfonycasts_sass' => [ | ||
| 'root_sass' => [ | ||
| '%kernel.project_dir%/assets/scss/app.scss', | ||
| '%kernel.project_dir%/assets/admin/scss/app.scss', | ||
| ], | ||
| ], | ||
| ], | ||
| 'Invalid configuration for path "symfonycasts_sass.root_sass": The "root_sass" paths need to end with unique filenames.'); | ||
| } | ||
| } | 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though probably if we want to link this directly from the vendor - it may require the
phpstan/phpstan-symfonypack, but probably only that one,phpstan/phpstanis redundant I think.Btw, I suppose this line fixed that ignored error message you deleted below, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it did :)