This repository was archived by the owner on Aug 14, 2019. It is now read-only.
Permissions name mismatch fix#84
Open
bartoszpietrzak1994 wants to merge 3 commits intoSylius:masterfrom
Open
Conversation
bartoszpietrzak1994
force-pushed
the
permissions-name-mismatch-fix
branch
from
9107d18 to
319fa7e
Compare
GSadee
approved these changes
May 17, 2019
Zales0123
approved these changes
May 20, 2019
|
|
||
| public function __construct() | ||
| { | ||
| $this->sectionsToPermissionsMapping = [ |
Contributor
There was a problem hiding this comment.
It could be initialized not in the constructor, but in private $sectionsToPermissionsMapping; 🚀 It could then also be a static variable, I suppose
| $availableSyliusSections = $this->syliusSectionsProvider->__invoke(); | ||
| $availablePermissions = array_map(function (string $section): string { | ||
| return $this->sectionsToPermissionsMapper->map($section); | ||
| }, $this->syliusSectionsProvider->__invoke()); |
Contributor
There was a problem hiding this comment.
We could extract this to the private function (provideAndMapPermissions?) to make the main function more readable
Zales0123
added
the
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.