Prelaunch cleanup#88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I've gotten this interview to an MVP launch state. It's a very low MVP (mostly just a fallible form with big empty blocks for text). It's saddled with a lot of complicated language that the court wanted to mirror the only informal brief program text, but they gave us sign off on the language. This has flagged a lot of plain language warnings. That being said, I've collected up some suggestions and question to follow up with the court. Mostly these changes represent making sure the document upload and user flow make sense and that everything actually makes it into the docs. There was also an emphasis on making sure the edit screens worked.
Also, I ran into a second mandatory=true as part of a code block defining menu_items and wasn't sure what to make of that. I commented it out to stop the linter from hanging up.