Add InterviewId param to EfspConnection and ProxyConnection classes - #312
Merged
Conversation
BryceStevenWilley
force-pushed
the
interview_id
branch
2 times, most recently
from
July 23, 2026 18:44
bd447a8 to
cb30b17
Compare
Member
|
The name "interviewID" is a little confusing. As I understand it, it's just the package plus interview filename. To me it sounds like it would be a session identifier. What about: interviewName, interviewFilename, or interviewPath? (it's technically a prefixed filename) |
BryceStevenWilley
force-pushed
the
interview_id
branch
2 times, most recently
from
July 23, 2026 20:17
1c3a20c to
6eeb25b
Compare
Automatically get it from the docassemble context, if that's present.
BryceStevenWilley
force-pushed
the
interview_id
branch
from
July 23, 2026 21:04
6eeb25b to
0df1da8
Compare
Contributor
Author
|
Went with interviewName, mostly because that's what we're using it as; it doesn't need to be the filename or the path, that's just the quickest way to get a unique, human readable name for the interview. Interview is also a slight misnomer, since LITEfile is likely going to use this as well, but it's still clear enough I think, this is an internal thing that we don't have to really explain to end-users or justify to external clients (if there are any) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically get it from the docassemble context, if that's present.
The other part of SuffolkLITLab/EfileProxyServer#416, wrote it when testing the feature on the proxy server, so figured I should just make the PR.