Make interview intro prompt translatable instead of hardcoded string#980
Merged
Conversation
Member
Author
|
This isn't necessarily urgent, but should be a small review. Keep running into student interviews getting flagged by DAYamlChecker this week and hoping to prevent that. |
BryceStevenWilley
approved these changes
Jun 11, 2026
BryceStevenWilley
left a comment
BryceStevenWilley
left a comment
Contributor
There was a problem hiding this comment.
LGTM, not tested myself though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes stray/unnecessary document (
---) marker at beginning of the generated YAML.Improves translatability of some hardcoded strings in the generated output of the Weaver, to help it pass out of the box DAYamlChecker
Fix #942
Fix #951
This includes turning
.titleof theALDocumentandALDocumentBundleintoDALazyTemplates. There are a handful of places that the function signature says .title will be a string upstream in AssemblyLine.al_document, so I am opening a separate PR to ensure those are handled properly.Overall, this should make it possible to take Weaver output and more easily translate the full document. I've already been manually making these changes in existing interviews so they pass DAYamlChecker's tests.