[codex] Support docassemble 1.10 webapp APIs#259
Draft
nonprofittechy wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258.
What changed
aldashboard.pyfrom removeddb_objectandModel.queryAPIs toget_session(),session_scope(), and SQLAlchemy 2select()statements.Root cause
Docassemble 1.10 split the legacy
docassemble.webapp.server,backend, andfilesmodules into smaller packages, removeddb_object, and changed its ORM models so they no longer expose Flask-SQLAlchemy'sModel.queryproperty. Updating import paths alone therefore fixed import-time errors but left dashboard user/session operations broken at runtime.Impact
ALDashboard imports and registers its routes on docassemble 1.10 while retaining compatibility with pre-1.10 installations. Database reads now use explicit sessions and writes use transactional session scopes in both compatibility branches.
Validation
python -m pytest -q— 363 passedpython -m mypy docassemble/ALDashboard --config-file pyproject.tomlpython -m compileall -q docassemble/ALDashboardnode --check docassemble/ALDashboard/data/static/pdf_labeler.jsDatabase queries were not executed against a live docassemble database; the session and query paths are covered structurally and by the full unit suite.