Skip to content

Remove TylerEnv from CodeDatabase#408

Merged
BryceStevenWilley merged 5 commits into
mainfrom
codes-db-cleanup
Jul 7, 2026
Merged

Remove TylerEnv from CodeDatabase#408
BryceStevenWilley merged 5 commits into
mainfrom
codes-db-cleanup

Conversation

@rajeswari1301

@rajeswari1301 rajeswari1301 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The code database was tagging every row with 'illinois-stage' instead of just 'illinois' because CodeDatabase was accepting a TylerDomain, which combined the jurisdiction and the env together. The env does not belong here, as one database should only ever serve one jurisdiction.

To fix this, I changed CodeDatabase and CodeDatabaseAPI to accept the Jurisdiction directly., and wrote a migration (which strips '-stage' and '-prod') to clean up existing rows, and updated all callers to follow the same pattern used in recent refactors.

Resolves #400

@BryceStevenWilley BryceStevenWilley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the change works well, but there are still some leftover names / references to domain that are no longer the domain but the jurisdiction that should be changed.

Comment thread proxyserver/src/main/java/edu/suffolk/litlab/efsp/ecfcodes/CodeDatabaseAPI.java Outdated

@BryceStevenWilley BryceStevenWilley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm going to wait to merge until after I do the next release tomorrow morning, this DB migration should probably go into its own release.

rajeswari1301 and others added 5 commits July 7, 2026 09:19
Co-authored-by: Copilot <copilot@github.com>
Renamed the domain col to jurisdiction in the migration, updated all the SQL helper files, renamed `getDomain` to `getJurisdiction` and `domainStr` to `jurisStr`, and replaced Tylerdomain with Jurisdiction in `TylerModuleSetup` since the env isn't needed there anymore

Co-authored-by: Copilot <copilot@github.com>
…/tyler/TylerModuleSetup.java

Co-authored-by: Bryce Willey <bryce.willey@suffolk.edu>
@BryceStevenWilley BryceStevenWilley merged commit 56701a9 into main Jul 7, 2026
4 checks passed
@BryceStevenWilley BryceStevenWilley deleted the codes-db-cleanup branch July 7, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove TylerEnv from the CodesDatabase

2 participants