Repository navigation
Set unused/unnecessary argument as optional - #3811
Open
randallbrenes wants to merge 1 commit into
Open
randallbrenes wants to merge 1 commit into
randallbrenes wants to merge 1 commit into
Conversation
randallbrenes
commented
Nov 16, 2026
| * @return bool @return bool | ||
| */ | ||
| protected function searchMatchName($name, $query, $path) | ||
| protected function searchMatchName($name, $query, $path = null) |
Author
There was a problem hiding this comment.
Actual change, all other are made by php linter
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some plugins, such as File Manager Advanced, only pass 2 arguments—since the third one is not used—but this causes an error in recent versions of PHP. Making this third argument optional resolves the issue, and it also ensures there are no compatibility problems if a plugin happens to provide that third parameter.
Error on server to avoid:
AFM elFinder connector error: Too few arguments to function elFinderVolumeDriver::searchMatchName(), 2 passed in .../public_html/wp-content/plugins/file-manager-advanced/application/class_fma_local_filesystem.php on line 230 and exactly 3 expected