fix: Add disableshadowdepth KV to static props #280
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smaedd
force-pushed
the
fix/staticprop-shadowdepth
branch
from
99fb9c1 to
7af9d23
Compare
Smaedd
force-pushed
the
fix/staticprop-shadowdepth
branch
from
7af9d23 to
cdd2c68
Compare
pivotman319-owo
approved these changes
Oct 10, 2025
Member
pivotman319-owo
left a comment
pivotman319-owo
left a comment
There was a problem hiding this comment.
Looks good, will merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
disableshadowdepthKV was missing which led to confusion about how to disable clustered shadows for static props (engine#1435). This seems to be caused byprop_staticnot usingBaseEntityAnimatingas a base, for various reasons, so I've added the KV directly toprop_staticto match the other shadow-related KVs.