implement global keyboard shortcut#663
Merged
Merged
Conversation
|
@shadrach68 is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@shadrach68 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
PR under review. I will drop a review if I find any wrong implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #591
This PR implements a robust, accessible global keyboard shortcut system for the Web3 Student Lab platform to improve efficiency for frequent users and power users.
Changes Made
layout.tsx. It useshotkeys-jsto listen for key combinations and dispatch custom events or trigger Next.js router navigations.<dialog>based modal to display all available shortcuts. It can be toggled usingCtrl/Cmd + KorCtrl/Cmd + Shift + H.ThemeToggle.tsxto listen for the customtheme-toggleevent (Ctrl/Cmd + Shift + T).page.tsxto correctly listen for theplayground-compileevent on thedocument(Ctrl/Cmd + Shift + C).<kbd>tags in the help modal.KeyboardShortcuts.test.tsxandKeyboardShortcutsProvider.test.tsxachieving >90% coverage for the new module.Available Shortcuts
Ctrl/Cmd + KorCtrl/Cmd + Shift + HG + CG + RG + VG + DCtrl/Cmd + Shift + TCtrl/Cmd + Shift + CAcceptance Criteria
How to Test
npm run dev).Cmd+KorCtrl+Kto open the help modal. Click outside or use the 'X' to close it.GthenC(Catalog),GthenR(Roadmap), etc.Cmd+Shift+TorCtrl+Shift+Tto toggle the application theme./playground, focus outside the editor, and pressCmd+Shift+CorCtrl+Shift+Cto trigger compilation.npm testornpx vitest runin the frontend directory.