Implement Keyboard Navigation for All Interactive Elements#649
Open
Emmy6654 wants to merge 2 commits into
Open
Implement Keyboard Navigation for All Interactive Elements#649Emmy6654 wants to merge 2 commits into
Emmy6654 wants to merge 2 commits into
Conversation
…t and skip links - Add keyboard navigation utilities (KEYS, FOCUSABLE_SELECTOR, focus helpers, arrow/grid nav) - Add useGlobalShortcuts, useArrowNavigation, useTypeAhead, useKeyboardNavigation, useFocusVisible hooks - Add useFocusTrap hook with Tab/Shift+Tab cycling, Escape handling, return focus on deactivate - Add useRovingTabindex hook for WAI-ARIA roving tabindex patterns - Add SkipLink component with multiple focus targets and SkipLinkTarget wrapper - Add FocusTrap component wrapping useFocusTrap - Integrate focus trap into Dialog component with aria-modal - Update root layout with enhanced skip links - Add keyboard navigation CSS (skip-link, forced-colors, focus-visible for ARIA roles) - Add setup cleanup to test infrastructure - 115 comprehensive unit tests across 6 test files with >90% coverage Closes StellarDevHub#650
feat: full keyboard navigation support with focus management and skip links
|
@Emmy6654 is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Emmy6654 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #600
Summary
Implements comprehensive keyboard navigation support for all interactive elements with focus management and skip links, ensuring equal access for all students.
Changes
New files
src/lib/keyboard-navigation.ts— Core keyboard utilitiessrc/hooks/useKeyboardNavigation.ts— Global shortcuts, arrow navigation, type-ahead, focus-visiblesrc/hooks/useFocusTrap.ts— Focus trapping for modalssrc/hooks/useRovingTabindex.ts— WAI-ARIA roving tabindexsrc/components/ui/SkipLink.tsx— Skip-to-content with multiple targetssrc/components/ui/FocusTrap.tsx— FocusTrap componentModified files
Testing
Closes #603
express-rate-limit+ oldapiRateLimiterwith newrateLimitermiddlewareconfig.rateLimiting.enabledModified:
backend/src/config/env.config.tsrateLimitingconfig section with env-var-backed settingsModified:
backend/.env.exampleRATE_LIMIT_*environment variables with documentationConfiguration via environment variables
RATE_LIMIT_ENABLEDRATE_LIMIT_BURST_MAXRATE_LIMIT_SUSTAINED_MAXRATE_LIMIT_AUTH_BURST_MAXRATE_LIMIT_AUTH_SUSTAINED_MAXRATE_LIMIT_ADMIN_BURST_MAXRATE_LIMIT_ADMIN_SUSTAINED_MAXRATE_LIMIT_LOGIN_BURST_MAXRATE_LIMIT_REGISTER_BURST_MAXTesting