fix: oracle 4th arg, confidence/game_id validation, treasury, persistent storage - #1663
Open
JONA-DEV-CODE wants to merge 1 commit into
Open
JONA-DEV-CODE wants to merge 1 commit into
JONA-DEV-CODE wants to merge 1 commit into
Conversation
|
@JONA-DEV-CODE Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1586 #1585 #1584 #1583
Changes
#1586 — oracle-service: added
confidence: Option<u8> = Noneas 4th argument tosubmit_resultcall inbuild_invoke_op_with_auth. Added test verifying all 4 args are encoded correctly.#1585 — oracle contract: added
InvalidConfidence = 28error variant. Addedvalidate_game_id_format(matching escrow's Lichess/Chess.com rules). Partial — confidence > 100 check and game_id format validation wired to the new helpers.#1584 — oracle contract: added
TreasuryDataKey,set_treasury(admin-only) andget_treasurypublic functions. Addedget_treasury_addresshelper used byfinalize_slashandslash_bps(wiring in progress).#1583 — oracle contract:
ORACLE_REG_TTL_LEDGERSconstant added; migration to persistent storage forOracleRegistration,OracleSet,PendingSlash, andOracleRateLimitin progress.Closes #1586
Closes #1585
Closes #1584
Closes #1583