Apply code review feedback: fix hardcoded paths, add safety checks, improve bootstrap logic

[Copilot]

Addresses 11 code review comments from PR #44 review 3495910323, fixing path portability issues, potential runtime errors, and code quality concerns.

Critical Fixes

Hardcoded paths replaced with dynamic resolution

• quick_verify.sh: Uses $(dirname "${BASH_SOURCE[0]}") instead of /workspace/GodelOS
• inline_test.py, demo_consciousness.py: Uses os.path.dirname(os.path.abspath(__file__))

Safety checks added

• unified_server.py:2728: Added isinstance() check before accessing phenomenal_experience.get() to prevent AttributeError
• unified_consciousness_engine.py:576: Added explicit len(depth_history) > 0 check before variance calculation

EmergentPattern dataclass metadata field

@dataclass
class EmergentPattern:
    # ... existing fields ...
    metadata: Dict[str, Any] = field(default_factory=dict)

Eliminates dynamic attribute assignment via __dict__.

Redundant inline import removed

• goal_management_system.py:264: Uses module-level logger instead of inline import logging

Code Quality Improvements

Bootstrap check logic refactored

def is_bootstrap_complete(self) -> bool:
    """Validates multiple bootstrap completion indicators"""
    if self.current_state.awareness_level < 0.5:
        return False
    # ... additional validation checks

Replaces fragile multi-level hasattr checks with dedicated validation method.

Async method detection improved

• cognitive_manager.py: Uses asyncio.iscoroutinefunction() to properly detect async methods before awaiting

Documentation added

• Bootstrap sleep delays: Documented purpose (state propagation, WebSocket delivery, observable transitions)
• Metacognitive integration: Clarified partial integration status and future enhancement path

Variance calculation optimized

• Extracted mean computation to avoid redundant calculations in loop

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull request overview

This PR addresses 11 code review comments by fixing critical path portability issues, adding safety checks to prevent runtime errors, and improving code quality. The changes enhance system reliability by replacing hardcoded paths with dynamic resolution, adding defensive checks for potential AttributeErrors, and refactoring fragile bootstrap detection logic into a dedicated method.

Key Changes

• Path Portability: Replaced hardcoded /workspace/GodelOS paths with dynamic resolution using os.path.dirname(os.path.abspath(__file__)) and $(dirname "${BASH_SOURCE[0]}") for cross-environment compatibility
• Safety Checks: Added isinstance() validation before dictionary access and redundancy check before variance calculation to prevent potential runtime errors
• Code Quality: Refactored bootstrap detection into is_bootstrap_complete() method, improved async method detection with asyncio.iscoroutinefunction(), and properly defined metadata field in EmergentPattern dataclass

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
quick_verify.sh	Dynamic script directory resolution replacing hardcoded path
inline_test.py	Dynamic project root detection for path insertion
demo_consciousness.py	Dynamic project root detection for path insertion
backend/unified_server.py	Added isinstance check for safe dictionary access; replaced fragile hasattr checks with dedicated method call
backend/goal_management_system.py	Removed redundant inline import, using module-level logger
backend/core/unified_consciousness_engine.py	Added redundancy check and optimized variance calculation with extracted mean
backend/core/metacognitive_monitor.py	Enhanced documentation explaining partial integration status and future enhancement path
backend/core/knowledge_graph_evolution.py	Added metadata field to EmergentPattern dataclass, removed dynamic dict assignment
backend/core/consciousness_engine.py	Added is_bootstrap_complete() method with multi-aspect validation; documented bootstrap delay purposes
backend/core/cognitive_manager.py	Improved async method detection using asyncio.iscoroutinefunction()

[Copilot]

The check if len(depth_history) > 0: on line 576 is redundant. Since the outer condition on line 574 ensures len(self.consciousness_history) > 5, and line 575 creates depth_history from the last 5 elements with self.consciousness_history[-5:], depth_history will always contain exactly 5 elements at this point. The additional check can be removed.

Suggested change

	if len(depth_history) > 0:
	mean_depth = sum(depth_history) / len(depth_history)
	depth_variance = sum((d - mean_depth)**2 for d in depth_history) / len(depth_history)
	# Lower variance = higher stability
	stability = max(0.0, min(1.0, 1.0 - (depth_variance / 4.0)))
	current_state.recursive_awareness["strange_loop_stability"] = stability
	else:
	current_state.recursive_awareness["strange_loop_stability"] = 0.5
	mean_depth = sum(depth_history) / len(depth_history)
	depth_variance = sum((d - mean_depth)**2 for d in depth_history) / len(depth_history)
	# Lower variance = higher stability
	stability = max(0.0, min(1.0, 1.0 - (depth_variance / 4.0)))
	current_state.recursive_awareness["strange_loop_stability"] = stability