feat: wire useNotifications hook to notificationApi, delete stub service - #624
Merged
Cedarich merged 1 commit intoAug 28, 2026
Merged
Conversation
- Rewrite hooks/useNotifications.ts to fetch from notificationApi.list() and update state only on successful markAsRead/markAllAsRead API calls - Expose loading, error, and reload from the hook - Refactor app/(tabs)/notifications.tsx to consume useNotifications hook (loading skeleton, empty, and error states all retained) - Delete services/NotificationService.ts (hardcoded stub) - types/notification.ts is now the single source of notification types - Update __tests__/useNotifications.test.ts to mock notificationApi; expand coverage to 6 tests — all 69 project tests pass
|
@jbeloved700 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a PR description you can use:
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Wire useNotifications to notificationApi · delete stub service
Summary
Replaces the hardcoded NotificationService stub with real API calls through the existing notificationApi in
services/api.ts. The hook now drives the notifications screen rather than each managing state independently.
Changes
hooks/useNotifications.ts — rewritten
app/(tabs)/notifications.tsx — refactored
services/NotificationService.ts — deleted
tests/useNotifications.test.ts — updated
Testing
pnpm test --no-coverage # 69 passed, 9 suites
pnpm type-check # no errors
closes #551