Get-AdoPicklist -Orphan bugfix for on-premises AzD Server #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect URL handling for on-premises Azure DevOps Server in the Get-ADOPicklist function when the -Orphan switch is used. Additionally, it introduces API version warnings to encourage users to upgrade from the outdated 5.0 API version to 7.0 or later.
Key Changes:
- Fixed URL construction for on-premises Azure DevOps Server in
Get-ADOPicklistorphan picklist detection - Added API version 5.x compatibility warnings across multiple functions (
Get-ADOPicklist,Get-ADOField,Remove-ADOPermission) - Code formatting improvements (brace placement standardization)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Functions/AzureDevOps/Get-ADOPicklist.ps1 | Added conditional logic to handle on-premises server URLs correctly when detecting orphaned picklists, and added API version warning |
| Functions/AzureDevOps/Get-ADOField.ps1 | Added API version 5.x compatibility warning for field operations |
| Functions/AzureDevOps/Remove-ADOPermission.ps1 | Added API version 5.x compatibility warning and standardized brace formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| $allPicklists = Get-ADOPicklist -Organization $organization | ||
| $allUsedPicklists = Get-ADOField @invokeParams -Organization $Organization | | ||
| $allPicklists = @() | ||
| $allUsedPicklists = @() |
There was a problem hiding this comment.
These variables are initialized but then immediately reassigned in both branches of the if-else statement. The initialization is redundant and should be removed to improve code clarity.
Suggested change
| $allUsedPicklists = @() |
norschel
force-pushed
the
topics/AzD_Server_Bugfix_Get_ADO_Picklist
branch
2 times, most recently
from
3ffa275 to
347e4f9
Compare
added 4 commits
October 24, 2025 11:35
…n Get-ADOPicklist for AzD Server
…rmission function
norschel
force-pushed
the
topics/AzD_Server_Bugfix_Get_ADO_Picklist
branch
from
347e4f9 to
c13f994
Compare
Co-authored-by: Copilot <[email protected]>
…ng in Remove-ADOPicklist function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes incorrect URL handling for on-premises Azure DevOps Server in the get-adopicklist function when the -orphan switch is used.
In addition, users are now warned when using the outdated 5.0 API version and encouraged to switch to version 7.0 (AZD 2022).