Fix Unit Tests & Introduce AST Based Validation - #49
Merged
Conversation
…end of file in tests
FilledStacks
approved these changes
Aug 6, 2025
FilledStacks
left a comment
FilledStacks
left a comment
Contributor
There was a problem hiding this comment.
This is fucking dope dude!
The test stability will help a lot. Thanks for putting in the effort to fix that up.
FilledStacks
added a commit
that referenced
this pull request
Aug 7, 2025
* chore(deps): upgrade logger to 2.0.1 (#18) BREAKING CHANGE * upgrade logger to 2.0.1 * exchange pretty printer default values * adjust unit tests for logger * remove warnings --------- Co-authored-by: Fernando Ferrara <ferrarafer@gmail.com> * fix: update SDK constraints * refactor: migrate to analyzer element2 API and update dependencies (#48) - Updated imports from `element.dart` to `element2.dart` across multiple files to utilize the new API. - Refactored parameter handling in various generator classes to accommodate changes in the element API. - Enhanced logging functionality with improved PrettyPrinter integration. - Removed redundant comments and improved code formatting for better readability. - Updated pubspec.yaml to reflect new dependency versions and SDK constraints. - Modified test cases to ensure compatibility with async operations. * Fix Unit Tests & Introduce AST Based Validation (#49) * Adds support for nested route naming with parent class context * refactor: update form view model extensions and improve validation logic * test: implement AST-based validation for router class generation * fix: remove unnecessary formatting fix command and ensure newline at end of file in tests --------- Co-authored-by: Sebastian Büchler <42775578+sebastianbuechler@users.noreply.github.com> Co-authored-by: Fernando Ferrara <ferrarafer@gmail.com> Co-authored-by: Aymen Nurhussen <37356773+Eimen2018@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances the router extension builder to support nested route naming and improves test infrastructure with AST (Abstract Syntax Tree) based validation for better reliability.
Key Changes
Router Enhancement
navigateToNestedViewInParentClassinstead of genericnavigateToViewForm Generator Updates
FormViewModeltoFormStateHelperfor consistencyTest Infrastructure Overhaul
RouterAstValidatorprovides semantic code structure validation instead of format-dependent comparisonsBreaking Changes
None. All changes are backward compatible.
Migration Notes
No migration required. This is an enhancement that improves existing functionality without changing public APIs.